Make Discover table keyboard accessible. #11604
Conversation
cjcenizal
added
Team:Platform-Design
cjcenizal
force-pushed
the
11541/bug/discover-table-tabbable
branch
from
672777c to
a6e2732
Compare
| ></i> | ||
| <button | ||
| class="doc-viewer-button" | ||
| ng-click="filter(mapping[field], flattened[field], '+')" |
There was a problem hiding this comment.
Oops, this should still be toggleColumn(field), right?
| > | ||
| <i | ||
| class="fa fa-columns" | ||
| ng-click="toggleColumn(field)" |
There was a problem hiding this comment.
Shouldn't need this any more, right?
| @@ -48,6 +60,13 @@ uiModules.get('kibana') | |||
| controller: function ($scope) { | |||
| $scope.mode = docViews.inOrder[0].name; | |||
| $scope.docViews = docViews.byName; | |||
|
|
|||
| $scope.onKeyUp = function onKeyUp(e, name) { | |||
There was a problem hiding this comment.
Hmm, for some reason this doesn't appear to be working. Notice how when I click on it, the view changes modes successfully, but when I tab and hit enter, it doesn't. (My guess is that it probably has something to do with $parent scope, since mode is directly on the $scope object which always causes problems.)
There was a problem hiding this comment.
I think the directive I made in #11604 will help me with this. I'll merge that PR first and then try to fix this.
cjcenizal
force-pushed
the
11541/bug/discover-table-tabbable
branch
from
280049a to
a9b08d4
Compare
|
@lukasolson I applied the @Bargs Would you mind reviewing too? |
|
Sure thing, I'll get to this tomorrow. I was just waiting on the rebase from #11591 |
* Make Discover table carets tabbable. * Make Discover table tabs tabbable. * Make Discover table icon buttons tabbable.
* Make Discover table carets tabbable. * Make Discover table tabs tabbable. * Make Discover table icon buttons tabbable.
Since #11604 the background of the filter icons in the document table remained visible and covered part of the cell content even when the cell was not hovered. That was caused by moving from display: none on the filter div to opacity: 0 on the individual icons. This PR moves the background styles from the filter div to the individual icons to prevent it from covering cell content when not hovered.
Blocked by #11591
Partially addresses #11541. Complements #11591.
TODO